screenShield: Activate dialog when necessary

Activating a dialog is slightly different from opening it; the
former is about showing the user authentication widgetry, while
the latter is about creating it and pre-allocating the necessary
resources.

Activate the screen shield dialog when necessary.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/872

diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index 503245a5742d2705136d207c038794d8c62779f5..519f97f7906cee19ae572577749e8df7a7d3a980 100644 (file)
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -1228,13 +1228,18 @@ var LoginDialog = GObject.registerClass({
         return GLib.SOURCE_REMOVE;
     }
 
+    activate() {
+        this._userList.grab_key_focus();
+        this.show();
+    }
+
     open() {
         Main.ctrlAltTabManager.addGroup(this,
                                         _("Login Window"),
                                         'dialog-password-symbolic',
                                         { sortGroup: CtrlAltTab.SortGroup.MIDDLE });
-        this._userList.grab_key_focus();
-        this.show();
+        this.activate();
+
         this.opacity = 0;
 
         Main.pushModal(this, { actionMode: Shell.ActionMode.LOGIN_SCREEN });

diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
index 5908ff5477430855440de704fce030ed7ee44271..b2b7c8a9537ed86602064cc82b8fa6e0c91ff853 100644 (file)
--- a/js/ui/screenShield.js
+++ b/js/ui/screenShield.js
@@ -159,8 +159,8 @@ var ScreenShield = class {
 
     _liftShield() {
         if (this._isLocked) {
-            if (this._ensureUnlockDialog(true /* allowCancel */))
-                this._hideLockScreen(true /* animate */);
+            this._ensureUnlockDialog(true /* allowCancel */);
+            this._dialog.activate();
         } else {
             this.deactivate(true /* animate */);
         }
@@ -437,6 +437,7 @@ var ScreenShield = class {
         }
 
         this._dialog.allowCancel = allowCancel;
+        this._dialog.grab_key_focus();
         return true;
     }
 

diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js
index 7b9b0e723b7fddd45818ddac107d2c5b2c0cc82c..f158d057c36147417cb8ff3badc30f09d671127c 100644 (file)
--- a/js/ui/unlockDialog.js
+++ b/js/ui/unlockDialog.js
@@ -527,6 +527,10 @@ var UnlockDialog = GObject.registerClass({
         return true;
     }
 
+    activate() {
+        this._showPrompt();
+    }
+
     popModal(timestamp) {
         if (this._isModal) {
             Main.popModal(this, timestamp);